Make audioPlayer public on MapboxVoiceController #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The “Verify UTF-8 strings files” step in CI is failing because of unrelated local diffs produced by the CocoaPods integration test. |
|
/cc @ericdeveloper |
1ec5
reviewed
Aug 14, 2018
| /** | ||
| An `AVAudioPlayer` through which spoken instructions are played. | ||
| */ | ||
| public var audioPlayer: AVAudioPlayer? |
There was a problem hiding this comment.
Should this property be available to Objective-C code?
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| * Fixed an issue where the steps list drag handlebar disappears whenever the user taps the resume button. ([#1588](https://github.com/mapbox/mapbox-navigation-ios/pull/1588)) | |||
| * Resolved the partially styled user interface issue that occurs when the style theme is switched between the `NightStyle` and `DayStyle`, after the resume button was tapped. ([#1589](https://github.com/mapbox/mapbox-navigation-ios/pull/1589)) | |||
| * Fixed a rare crash associated with the keyboard when showing the end of route view controller. [#1599](https://github.com/mapbox/mapbox-navigation-ios/pull/1599/) | |||
| * Made the AVAudioPlayer on MapboxVoiceController public. [#1596](https://github.com/mapbox/mapbox-navigation-ios/pull/1596) | |||
There was a problem hiding this comment.
As far as the developer is concerned, this property never existed before:
- Added a
MapboxVoiceController.audioPlayerproperty. You can use this property to interrupt a spoken instruction or adjust the volume.
|
This could be one half of #1598, though it doesn’t help application code to coordinate AVSpeechSynthesizer utterances when Polly is unavailable. |
1ec5
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
audioPlayeroff of RouteVoiceController and moves it to MapboxVoiceController and also makes it public.audioPlayerwas never used directly on RouteVoiceController but rather only used on the subclassed class MapboxVoiceController.This is useful for custom UI implementations- when the user leaves navigation mode, the developer should be able to interrupt the current voice instruction.
/cc @mapbox/navigation-ios