Public StepsListViewController #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsudekum
commented
Aug 29, 2018
| controller.view.topAnchor.constraint(equalTo: instructionsBannerView.bottomAnchor).isActive = true | ||
| controller.view.leadingAnchor.constraint(equalTo: view.leadingAnchor).isActive = true | ||
| controller.view.bottomAnchor.constraint(equalTo: view.bottomAnchor).isActive = true | ||
| controller.view.trailingAnchor.constraint(equalTo: view.trailingAnchor).isActive = true |
There was a problem hiding this comment.
I'm not a fan of how much boilerplate is necessary to make the slide action happen. @frederoni is there anything we can do to encapsulate this better?
There was a problem hiding this comment.
You could make UIView.pinInSuperview() public and replace these 4 lines w/
controller.view.pinInSuperview(). But pinInSuperview doesn't respect RTL so make sure you change left->leading and right->trailing in UIView.pinInSuperview()’s implementation if you decide to go that way.
frederoni
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to have the same steps list view functionality, that is found in the drop in UI, in a custom navigation UI. I think this is about the least intrusive change possible to have this work.
/cc @mapbox/navigation-ios