Fix u-turn direction #1647
Merged
Fix u-turn direction #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsudekum
approved these changes
Sep 4, 2018
1ec5
approved these changes
Oct 2, 2018
| @@ -69,3 +88,13 @@ class ManeuverViewTests: FBSnapshotTestCase { | |||
| // TODO: Figure out why the flip transformation do not render in a snapshot so we can test left turns and left side rule of the road. | |||
| } | |||
|
|
|||
| extension UIView { | |||
|
|
|||
| func asImage() -> UIImage { | |||
There was a problem hiding this comment.
Consider replacing this method with an initializer in a UIImage extension. That style is less “fluent” but also more consistent with the majority of the standard library.
There was a problem hiding this comment.
I agree but initializers on UIImage would require more steps and it's not particularly elegant since you can't return the instance. It would involve UIView->UIImage->CGImage(or any other type supported by UIImage->UIImage. So I went with a class function on UIImage instead, UIImage.from(_:).
frederoni
force-pushed
the
fred/fix-uturn
branch
6 times, most recently
from
b45a90c
to
4de17b6
Compare
frederoni
force-pushed
the
fred/fix-uturn
branch
from
4de17b6
to
afbf4b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arrow-180 asset used for u-turns in navigation-ui-resources is turning clockwise so we should flip it horizontally if it's right-hand rule of the road.
cc @akitchen @1ec5