Fold CarPlay-specific styles into main styles #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
op-ex
frederoni
reviewed
Sep 15, 2018
| */ | ||
| @objc open var mapStyleURL: URL = MGLStyle.navigationGuidanceDayStyleURL | ||
|
|
||
| #if canImport(CarPlay) |
There was a problem hiding this comment.
Do we need to wrap this block in a canImport? The URL is still available iOS < 12.
There was a problem hiding this comment.
The #else block below is identical except for the documentation comment. I figured it would make little sense to talk about CarPlay in the documentation if CarPlay is unavailable.
JThramer
approved these changes
Sep 15, 2018
1ec5
force-pushed
the
1ec5-carplay-merge-styles
branch
from
efe7ae7
to
52893ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed CarPlayDayStyle and CarPlayNightStyle in favor of using DayStyle and NightStyle in all user interface idioms. Vary ExitView and GenericShieldView by idiom.
Added a
Style.previewMapStyleURLproperty, which is used by CarPlayMapViewController but can also be used in the future for the preview view controller proposed by #808. In the meantime, the property is visible to applications for custom preview view controller implementations./cc @mapbox/navigation-ios