Revert user puck dead reckoning #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 07c8bdc.
|
Looks a lot better. Simulating at 9× is still suboptimal but this is an improvement. |
frederoni
approved these changes
Sep 17, 2018
This was referenced Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit #1385, which resulted in the puck overshooting at turns and detaching from the route line along curved roads. In some cases, it may have exacerbated other issues with course tracking.
When we revisit this feature in the future, we’ll need to ensure that dead reckoning is only part of the solution: the result of dead reckoning needs to be snapped to the route line. That wasn’t happening before, so this feature tended to foil any attempt at snapping the user’s location to the route line, at least visually. As well, we’ll need to find an alternative to
CLLocation.speed, which is an instantaneous reading that is documented to be unsuitable for dead reckoning./cc @mapbox/navigation-ios