Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location fallback for CarPlay navigation style #1762

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Oct 2, 2018

Copied the NavigationViewController.location(for:) implementation over to CarPlayNavigationViewController.location(for:) so that the CarPlay navigation map view can show the night style even before the navigation service is able to say where the day/night choice should be made from.

Fixes #1760.

/cc @JThramer @frederoni

@1ec5 1ec5 added bug Something isn’t working CarPlay Bugs, improvements and feature requests on Apple CarPlay labels Oct 2, 2018
@1ec5 1ec5 added this to the v0.22.1 milestone Oct 2, 2018
@1ec5 1ec5 self-assigned this Oct 2, 2018
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@1ec5 1ec5 merged commit a13afc7 into master Oct 2, 2018
@1ec5 1ec5 deleted the 1ec5-carplay-nav-style-location-1760 branch October 2, 2018 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working CarPlay Bugs, improvements and feature requests on Apple CarPlay
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants