Swipeable Banner Custom UI #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 10, 2018 13:40
Right now you're forced to always show the indicator even if your custom UI does not add it, this property allows this to be configurable so if you set this to false it will never appear
Without this method being public, you cannot build a custom navigation UI and move the map camera around without the puck flying around everywhere, this puts control in the developers hands
akitchen
approved these changes
Oct 10, 2018
akitchen
reviewed
Oct 10, 2018
| @@ -48,9 +48,18 @@ open class BaseInstructionsBannerView: UIControl { | |||
| @IBInspectable | |||
| public var swipeable: Bool = false | |||
|
|
|||
| @IBInspectable | |||
| public var showStepIndicator: Bool = true { | |||
There was a problem hiding this comment.
Could you please add a line in the changelog for this addition?
There was a problem hiding this comment.
sorry forgot will update!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstructionsBannerView.showStepIndicatorso we have control over whether we want to show the indicator in our custom UI or not. Not everyone will show the steps list from the top so this needs to be configurable.BaseInstructionsBannerView.init(frame: CGRect)public so we can actually initialize this outside of the SDK.NavigationMapView.enableFrameByFrameCourseViewTrackingpublic so when you want to move the map camera in navigation, this can help prevent the puck from flying across the screen.@mapbox/navigation-ios