Allow style customization in CarPlay #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
build
frederoni
approved these changes
Nov 14, 2018
|
Noticed that this build didn't trigger codecov. Would you mind trying a rebase before merging? |
Renamed CarPlayManager and CarPlayNavigationViewController initializers to accept Style objects, which are applied throughout the CarPlay interface, similar to NavigationViewController. DayStyle and NightStyle are still used by default but no longer hard-coded everywhere. Renamed the StyleManager initializer to rely on a delegate property instead of an argument that looks like it gives ownership of the delegate to StyleManager. Exposed a few more CarPlayManager members to Objective-C code.
1ec5
force-pushed
the
1ec5-carplay-custom-style-1823
branch
from
9cb923f
to
b5ca519
Compare
1ec5
added
the
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications can now customize the style of the map in CarPlay (nominally the rest of the CarPlay interface, but really just the map style).
Renamed
CarPlayManager(_:)toCarPlayManager(styles:eventsManager:)andCarPlayNavigationViewController(with:mapTemplate:interfaceController:manager:styles:)toCarPlayNavigationViewController(navigationService:mapTemplate:interfaceController:manager:styles:). These initializers now accept Style objects as arguments, which are applied throughout the CarPlay interface, similar to NavigationViewController. DayStyle and NightStyle are still used by default but no longer hard-coded everywhere. The application can setCarPlayManager.stylesat any time to change the map style, for example if it sets the style of NavigationViewController or a standalone NavigationMapView on the phone and needs to synchronize the change on CarPlay.Renamed
StyleManager(_:)toStyleManager(). The previous initializer looked like it gave ownership of the delegate to StyleManager, whereas it was just a weak reference. Client code is now expected to set thedelegateproperty explicitly.Exposed a few more CarPlayManager members to Objective-C code. Fixed some build warnings.
Fixes #1823.
/cc @mapbox/navigation-ios