Adding willArrive functionality to RouteController/NavigationService. #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JThramer
added
feature
1ec5
reviewed
Nov 22, 2018
| */ | ||
|
|
||
| @objc(navigationService:willArriveAtWaypoint:in:distance:) | ||
| optional func navigationService(_ service: NavigationService, willArriveAt waypoint: Waypoint, in eta:TimeInterval, distance: CLLocationDistance) |
There was a problem hiding this comment.
Nit: avoid abbreviations. More importantly, “ETA” is ambiguous: in this case, it means the remaining number of seconds (the remaining portion of the estimated travel time), but people might also be inclined to interpret “ETA” as the time at the time of arrival.
Suggested change
| optional func navigationService(_ service: NavigationService, willArriveAt waypoint: Waypoint, in eta:TimeInterval, distance: CLLocationDistance) | |
| optional func navigationService(_ service: NavigationService, willArriveAt waypoint: Waypoint, after remainingTimeInterval: TimeInterval, distance: CLLocationDistance) |
1ec5
reviewed
Nov 22, 2018
CHANGELOG.md
Outdated
| @@ -17,6 +17,7 @@ | |||
| * Fixed a crash during turn-by-turn navigation. ([#1820](https://github.com/mapbox/mapbox-navigation-ios/pull/1820)) | |||
| * Fixed a crash that could happen while simulating a route. ([#1820](https://github.com/mapbox/mapbox-navigation-ios/pull/1820)) | |||
| * Fixed an issue causing MapboxVoiceController to speak instructions using VoiceOver instead of the Mapbox Voice API. ([#1830](https://github.com/mapbox/mapbox-navigation-ios/issues/1830)) | |||
| * Added `RouterDelegate.router(_:willArriveAt:in:distance:)` to assist with preparations for arrival. ([#1847](https://github.com/mapbox/mapbox-navigation-ios/pull/1847)) | |||
There was a problem hiding this comment.
Suggested change
| * Added `RouterDelegate.router(_:willArriveAt:in:distance:)` to assist with preparations for arrival. ([#1847](https://github.com/mapbox/mapbox-navigation-ios/pull/1847)) | |
| * Added `RouterDelegate.router(_:willArriveAt:after:distance:)` to assist with preparations for arrival. ([#1847](https://github.com/mapbox/mapbox-navigation-ios/pull/1847)) |
There was a problem hiding this comment.
will change changed to NavigationViewControllerDelegate.navigationViewController(_:willArriveAt:after:distance:) since it's more relevant for most users.
| */ | ||
|
|
||
| @objc(navigationViewController:willArriveAtWaypoint:in:distance:) | ||
| optional func navigationViewController(_ navigationViewController: NavigationViewController, willArriveAt waypoint: Waypoint, in eta:TimeInterval, distance: CLLocationDistance) |
There was a problem hiding this comment.
Suggested change
| optional func navigationViewController(_ navigationViewController: NavigationViewController, willArriveAt waypoint: Waypoint, in eta:TimeInterval, distance: CLLocationDistance) | |
| optional func navigationViewController(_ navigationViewController: NavigationViewController, willArriveAt waypoint: Waypoint, after remainingTimeInterval: TimeInterval, distance: CLLocationDistance) |
| @@ -48,6 +48,10 @@ public class NavigationServiceDelegateSpy: NavigationServiceDelegate { | |||
| recentMessages.append(#function) | |||
| } | |||
|
|
|||
| public func navigationService(_ service: NavigationService, willArriveAt waypoint: Waypoint, in eta: TimeInterval, distance: CLLocationDistance) { | |||
There was a problem hiding this comment.
Suggested change
| public func navigationService(_ service: NavigationService, willArriveAt waypoint: Waypoint, in eta: TimeInterval, distance: CLLocationDistance) { | |
| public func navigationService(_ service: NavigationService, willArriveAt waypoint: Waypoint, after remainingTimeInterval: TimeInterval, distance: CLLocationDistance) { |
Co-Authored-By: frederoni <bjorn.fredrik.karlsson@gmail.com>
Co-Authored-By: frederoni <bjorn.fredrik.karlsson@gmail.com>
frederoni
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1844. Adds a new
router:willArriveAt:in:distance:(and friends) mechanism.To-do:
/cc @mapbox/navigation-ios