Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NavigationSettings.shared accessible in Objective-C #1882

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Make NavigationSettings.shared accessible in Objective-C #1882

merged 1 commit into from
Dec 4, 2018

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Dec 4, 2018 •
edited
Loading

The NavigationSettings.shared property is now accessible in Objective-C code as the class property MBNavigationSettings.sharedSettings.

/cc @frederoni @JThramer @riastrad

@1ec5 1ec5 added bug Something isn’t working Objective-C labels Dec 4, 2018
@1ec5 1ec5 added this to the v0.26.0 milestone Dec 4, 2018
@1ec5 1ec5 self-assigned this Dec 4, 2018
JThramer
JThramer approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharing is caring.

@1ec5 1ec5 merged commit 3221078 into master Dec 4, 2018
@1ec5 1ec5 deleted the 1ec5-shared-settings-objc branch December 4, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JThramer JThramer JThramer approved these changes

@frederoni frederoni Awaiting requested review from frederoni

Assignees

@1ec5 1ec5

Labels
bug Something isn’t working
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @JThramer