-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose offline routing functionality to Obj-C #1891
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
@import MapboxCoreNavigation; | ||
@import MapboxDirections; | ||
@import TestHelper; | ||
@import MapKit; | ||
|
||
@interface BridgingTests : XCTestCase | ||
@property (nonatomic) MBRouteController *routeController; | ||
|
@@ -41,6 +42,43 @@ - (void)testUpdateRoute { | |
_routeController.routeProgress = [[MBRouteProgress alloc] initWithRoute:route legIndex:0 spokenInstructionIndex:0]; | ||
[self waitForExpectations:@[expectation] timeout:5]; | ||
} | ||
|
||
// This test is excluded from the test suite. We are just verifying that offline routing bridges to Obj-C at compile time. | ||
- (void)testOfflineRouting { | ||
[[[MBDirections sharedDirections] fetchAvailableOfflineVersionsWithCompletionHandler:^(NSArray<NSString *> * _Nullable versions, NSError * _Nullable error) { | ||
|
||
NSArray <NSValue *> *coordinates = nil; | ||
coordinates = @[[NSValue valueWithMKCoordinate:CLLocationCoordinate2DMake(0, 0)], | ||
[NSValue valueWithMKCoordinate:CLLocationCoordinate2DMake(1, 1)]]; | ||
|
||
MBCoordinateBounds *bounds = [[MBCoordinateBounds alloc] init:coordinates]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
[[[MBDirections sharedDirections] downloadTilesIn:bounds version:versions.firstObject session:nil completionHandler:^(NSURL * _Nullable url, NSURLResponse * _Nullable response, NSError * _Nullable error) { | ||
|
||
NSURL *outputDirectoryURL = [[NSBundle mapboxCoreNavigation] suggestedTileURLWithVersion:versions.firstObject]; | ||
|
||
[MBNavigationDirections unpackTilePackAtURL:url outputDirectoryURL:outputDirectoryURL progressHandler:^(uint64_t totalBytes, uint64_t bytesRemaining) { | ||
// Show unpacking progress | ||
} completionHandler:^(uint64_t numberOfTiles, NSError * _Nullable error) { | ||
// Dismiss UI | ||
}]; | ||
|
||
}] resume]; | ||
}] resume]; | ||
|
||
MBNavigationRouteOptions *options = [[MBNavigationRouteOptions alloc] initWithLocations:@[] profileIdentifier:MBDirectionsProfileIdentifierCycling]; | ||
|
||
MBNavigationDirections *directions = nil; | ||
|
||
[directions calculateDirectionsWithOptions:options offline:YES completionHandler:^(NSArray<MBWaypoint *> * _Nullable waypoints, NSArray<MBRoute *> * _Nullable routes, NSError * _Nullable error) { | ||
|
||
}]; | ||
|
||
NSURL *url = [NSURL URLWithString:@""]; | ||
[directions configureRouterWithTilesURL:url translationsURL:url completionHandler:^(uint64_t numberOfTiles) { | ||
|
||
}]; | ||
} | ||
|
||
@end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we excluding it because the networking is currently unstubbed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, kind of. These tests are just to make sure we don't regress Obj-C bridging.
We have offline tests for fetching available versions, downloading tiles, and unpacking tiles written in Swift with stubbed network.