Upgrade to Mapbox Streets source v8 #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both label localization and feature querying for the current road name label now support styles powered by Mapbox Streets source v8. If the current style doesn’t use the Streets source, version 8 is now added automatically instead of v7.
frederoni
reviewed
Dec 19, 2018
| @@ -1006,7 +1006,8 @@ open class NavigationMapView: MGLMapView, UIGestureRecognizerDelegate { | |||
| } | |||
|
|
|||
| // Road labels should match road signage. | |||
| let locale = layer.sourceLayerIdentifier == "road_label" ? Locale(identifier: "mul") : nil | |||
| let isLabelLayer = MGLVectorTileSource.roadLabelLayerIdentifiersByTileSetIdentifier.values.contains(layer.sourceLayerIdentifier ?? "") | |||
| let locale = isLabelLayer ? Locale(identifier: "mul") : nil | |||
There was a problem hiding this comment.
What's "mul"? Doesn't seem to be supported by Locale 🤔. If so, won't this always evaluate to nil?
There was a problem hiding this comment.
mul is the ISO 639 identifier meaning “multilingual”. The map SDK maps this code to the name field. Since that field displays the local language for each feature, it effectively produces a multilingual map. Locale(identifier: "mul") is supported in the sense that its languageCode is mul, which is all we need for this API.
frederoni
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both label localization and feature querying for the current road name label now support styles powered by Mapbox Streets source v8. If the current style doesn’t use the Streets source, version 8 is now added automatically instead of v7.
Fixes #1896.
/cc @frederoni @JThramer