Rerouting customiztion rollback #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Udumft
added
release blocker
1ec5
approved these changes
Jan 11, 2022
| ### Location tracking | ||
|
|
||
| * Added the `RouterDelegate.router(_:initialManeuverBufferWhenReroutingFrom:)` method and related `NavigationServiceDelegate` and `NavigationViewControllerDelegate` methods to configure rerouting buffering. ([#3454](https://github.com/mapbox/mapbox-navigation-ios/pull/3454)) | ||
| * Added `RouterDelegate.router(_:requestBehaviorForReroutingWith:)` and related `NavigationServiceDelegate` and `NavigationViewControllerDelegate` methods to provide customization for rerouting mechanism by providing a user-defined route as a reroute. ([#3472](https://github.com/mapbox/mapbox-navigation-ios/pull/3472)) |
There was a problem hiding this comment.
😞 Looking forward to a revival of this useful feature!
…rous maneuver during rerouting and custom route providing mechanism. CHANGELOG entries removed too
Udumft
force-pushed
the
vk/rollback-reroute-customization
branch
from
fde0895
to
3f32db0
Compare
|
No breaking changes detected in MapboxCoreNavigation |
|
No breaking changes detected in MapboxNavigation |
This was referenced Mar 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rolls back configuration for dangerous maneuver during rerouting and custom route providing mechanism. This is required due to upcoming NavNative RerouteController integration which will be most likely incompatible with current implementation. In order to not publish API which may get unsupported in the next version, we do a rollback now.
Reverted features will be available in future versions (most likely 2.3.0).