Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace maneuver arrow #397

Merged
merged 3 commits into from
Aug 1, 2017
Merged

Replace maneuver arrow #397

merged 3 commits into from
Aug 1, 2017

Conversation

frederoni
Copy link
Contributor

@frederoni frederoni commented Jul 17, 2017

WIP #326

  • Replace the icon with a good looking one
  • Add styling capabilities to the maneuver arrow and shaft
  • Test

@bsudekum @ericrwolfe 👀

@frederoni frederoni requested a review from bsudekum July 17, 2017 18:44
@bsudekum
Copy link
Contributor

We should also figure out a better layer order here. How does it look underneath street labels?

@ericrwolfe
Copy link
Contributor

ericrwolfe commented Jul 18, 2017

Would love to see 2 arrowheads: a white one (or one that matches the main stroke) on top, with one that matches the case below and slightly increased in size to roughly match the case width. Also, the current arrowhead looks a little on the small side.

Also, we should change the line cap to .butt.

I think appearing over street labels will be fine, especially if we increase the arrow line width to correspond with the route line increase.

@1ec5
Copy link
Contributor

1ec5 commented Jul 21, 2017

We should also figure out a better layer order here. How does it look underneath street labels?

Placing the maneuver arrow below any shields, exit numbers, or street labels would be a simple fix. However, I’m concerned that putting anything atop the arrow would make the arrow more difficult to spot, making it look even more like a street. Here’s what it looks like on master if I make that change:

liberty 2nd

With the changes in this PR, the arrow would be less indistinguishable from a road – or a gap in the route line, even. Is there a good use case for reading the current road name off the base map, especially given that a label displays the same information, unrotated, at a consistent location on the screen?

@bsudekum bsudekum force-pushed the fred-replace-maneuver-arrow branch from f313598 to bac4307 Compare July 26, 2017 00:02
@ericrwolfe ericrwolfe modified the milestone: v0.7.0-1 Jul 27, 2017
@bsudekum bsudekum force-pushed the fred-replace-maneuver-arrow branch from bac4307 to 393bcd3 Compare August 1, 2017 16:30
@bsudekum
Copy link
Contributor

bsudekum commented Aug 1, 2017

Updated this with a new a white triangle:
simulator screen shot aug 1 2017 11 08 56 am

@ericrwolfe
Copy link
Contributor

That new arrow looks so much better 😄

@ericrwolfe
Copy link
Contributor

Add styling capabilities to the maneuver arrow and shaft

Let's do this as a separate PR cc @frederoni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants