-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace maneuver arrow #397
Conversation
We should also figure out a better layer order here. How does it look underneath street labels? |
Would love to see 2 arrowheads: a white one (or one that matches the main stroke) on top, with one that matches the case below and slightly increased in size to roughly match the case width. Also, the current arrowhead looks a little on the small side. Also, we should change the line cap to I think appearing over street labels will be fine, especially if we increase the arrow line width to correspond with the route line increase. |
Placing the maneuver arrow below any shields, exit numbers, or street labels would be a simple fix. However, I’m concerned that putting anything atop the arrow would make the arrow more difficult to spot, making it look even more like a street. Here’s what it looks like on master if I make that change: With the changes in this PR, the arrow would be less indistinguishable from a road – or a gap in the route line, even. Is there a good use case for reading the current road name off the base map, especially given that a label displays the same information, unrotated, at a consistent location on the screen? |
f313598
to
bac4307
Compare
bac4307
to
393bcd3
Compare
That new arrow looks so much better 😄 |
Let's do this as a separate PR cc @frederoni |
WIP #326
@bsudekum @ericrwolfe 👀