Prevent Polly from making UI laggy #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsudekum
changed the title
1ec5
reviewed
Aug 8, 2017
| @@ -111,18 +117,38 @@ public class PollyVoiceController: RouteVoiceController { | |||
| return | |||
| } | |||
|
|
|||
| do { | |||
| let soundData = try Data(contentsOf: url as URL) | |||
There was a problem hiding this comment.
Specifically, it was this line that was bogging down the UI.
| return | ||
| } else if let error = error { | ||
| // Cannot call super in a closure | ||
| strongSelf.callSuperSpeak(strongSelf.fallbackText, error: error.localizedDescription) |
There was a problem hiding this comment.
Do we need to call super’s speak(_:error:) specifically? Why not call self.speak(_:error:)?
There was a problem hiding this comment.
@1ec5 that would result in the polly voice controller trying to fetch a new polly mp3 if it were to fail. The idea here is that if it fails, it falls back to the default speech synth.
ericrwolfe
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try Data(contentsOf: url as URL)was really blocking up UI rendering. Removing this and moving to an async method for fetching data allows the UI to continue rendering while the data is fetched and unpacked. The UI during speaking is noticeably smoother./cc @willwhite @ericrwolfe @frederoni