Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common SDK logs #41

Merged
merged 2 commits into from
May 25, 2022
Merged

Common SDK logs #41

merged 2 commits into from
May 25, 2022

Conversation

DzmitryFomchyn
Copy link
Contributor

@DzmitryFomchyn DzmitryFomchyn commented May 24, 2022 •
edited
Loading

Description

This PR migrates logs implementation to the Common SDK Log. Closes https://github.com/mapbox/mapbox-search-android-internal/issues/786

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR (where applicable)
  • I have run tests and automatic checks locally
  • I have run pitest check locally and checked that the coverage increased (or didn't change) or decreased insignificantly
  • I have made corresponding changes to the documentation (where applicable)
  • I have grouped commits logically or I promise to squash my commits before merge

@DzmitryFomchyn DzmitryFomchyn requested review from a team as code owners May 24, 2022 21:07
@DzmitryFomchyn DzmitryFomchyn merged commit 0a818bc into main May 25, 2022
@DzmitryFomchyn DzmitryFomchyn deleted the df-common-sdk-logs branch May 25, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4rtzel 4rtzel 4rtzel approved these changes

@ChessProfessor ChessProfessor Awaiting requested review from ChessProfessor ChessProfessor is a code owner automatically assigned from mapbox/search-sdk

@sarochych sarochych Awaiting requested review from sarochych

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DzmitryFomchyn @4rtzel