Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onOpenChange handler for contextMenu #226

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Add onOpenChange handler for contextMenu #226

merged 3 commits into from
Sep 4, 2024

Conversation

miafan23
Copy link
Contributor

@miafan23 miafan23 commented Sep 3, 2024

@miafan23 miafan23 requested a review from a team as a code owner September 3, 2024 10:41
@miafan23 miafan23 requested a review from tristen September 3, 2024 10:45
Copy link
Member

@tristen tristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Just added a code suggestion for the semver as we are adding something new to the API.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@mapbox/mr-ui",
"version": "2.10.2",
"version": "2.10.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "2.10.3",
"version": "2.11.0",

@miafan23 miafan23 merged commit d9d81fd into main Sep 4, 2024
3 checks passed
@miafan23 miafan23 deleted the STUDIO-2766 branch September 4, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants