updates to travis matrix #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@springmeyer excellent! That's really settling. Going to work on getting tests 🍏 for travis now |
👍 one shortcut I'm very comfortable with: merging now and ensuring things pass in master. Reasoning is that I think the race condition will be lessened (or gone?) when we are not running two build jobs (like are run for PRs). Still need to solve the race condition, but that can be after release since it does not impact node-pre-gyp users (and is only a test issue). |
hyj1991
pushed a commit
to X-Profiler/node-pre-gyp
that referenced
this pull request
Jun 16, 2023
* updates to travis matrix * add v10 to appveyor * 6,8,9,10 * add abi 64 files for windows * add some logs for appveyor * use default NPM versions * explicitly install npm versions * EQU * install after npm version switch * use npm v2 * npm v2 for node v10 * remove consoles * please appveyor, let me shotgun debug successfully * try using cwd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the travis matrix to:
cc @springmeyer for review