Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop recommending bundling at all (or any other workaround) #403

Merged
merged 1 commit into from
Jul 9, 2018
Merged

stop recommending bundling at all (or any other workaround) #403

merged 1 commit into from
Jul 9, 2018

Conversation

springmeyer
Copy link
Contributor

@springmeyer springmeyer commented Jul 9, 2018 •
edited
Loading

With node versions > 4 all npm versions should be able to install node-pre-gyp correctly before needing to call it.

/cc @mapbox/core-tech

Avoids errors like:


npm ERR! node v6.0.0
npm ERR! npm  v3.8.6
npm ERR! path /Users/carol/dev/api-maps/node_modules/.staging/abbrev-2108b53f
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename

npm ERR! enoent ENOENT: no such file or directory, rename '/Users/carol/dev/api-maps/node_modules/.staging/abbrev-2108b53f' -> '/Users/carol/dev/api-maps/node_modules/@mapbox/vt_shaver/node_modules/abbrev'

Note abbrev is one package that this would happen with, but it seems like any package that would bundled would look like the culprit.

@springmeyer
stop recommending bundling at all (or any other workaround)
caae594 
With node versions > 4 all npm versions should be able to install `node-pre-gyp` correctly before needing to call it.
springmeyer added a commit to springmeyer/node-addon-example that referenced this pull request Jul 9, 2018
@springmeyer
stop bundling
7e91f05 
refs mapbox/node-pre-gyp/pull/403
springmeyer added a commit to mapbox/node-cpp-skel that referenced this pull request Jul 9, 2018
@springmeyer
stop bundling node-pre-gyp
35b0225 
We no longer want to bundle node-pre-gyp

refs mapbox/node-pre-gyp#403
@springmeyer springmeyer mentioned this pull request Jul 9, 2018
Merged
@springmeyer springmeyer merged commit 446c693 into master Jul 9, 2018
@springmeyer springmeyer deleted the unbundle-redux branch July 9, 2018 01:31
This was referenced Jul 16, 2018
Closed
Closed
Closed
Closed
Closed
@springmeyer springmeyer mentioned this pull request Jul 23, 2018
Closed
addaleax added a commit to addaleax/lzma-native that referenced this pull request Jul 26, 2018
@addaleax
package: stop bundling dependencies
b625b3e 
Refs: mapbox/node-pre-gyp#403
@springmeyer springmeyer mentioned this pull request Aug 12, 2018
Closed
hyj1991 pushed a commit to X-Profiler/node-pre-gyp that referenced this pull request Jun 16, 2023
@springmeyer
Merge pull request mapbox#403 from mapbox/unbundle-redux
1ffb0c3 
stop recommending bundling at all (or any other workaround)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@springmeyer