Simplify use of binaries off a local artifactory #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilatypov
added a commit
to ilatypov/node.bcrypt.js
that referenced
this pull request
Aug 31, 2018
Revert to using a deep path so that the local artifactory can host gyp binaries of different packages. A small change in node-pre-gyp will allow to use a single .npmrc variable to host binary requisites for many packages in one enterprise artifactory. mapbox/node-pre-gyp#416
Allow installing a package with many dependent packages using node-pre-gyp binaries off the same local artifactory. Avoid erasing the subpath in the mirror value.
Passing a tool-specific define confused gyp that expects tool-agnostic defines. nodejs/node-gyp#180
Follow node-pre-gyp treating --NAME=VALUE but not -DNAME=VALUE options specially. Correct tests for Windows binary output paths shown by the build tool.
Follow "node-gyp configure" and "rebuild" taking unparsed options where "node-gyp build" does not. https://github.com/nodejs/node-gyp/blob/master/lib/rebuild.js Correct the expectations of build output paths according to the directory separator. Simplify passing the "variables".
Also expect a PDB output on Windows.
4 tasks
..until fixing command line processing in Windows broken by a change making multi-target invokation possible in Windows, just like in other OSes, nodejs/node-gyp#1164 The change did not account for the special case of passing a define on command line.
|
The patch you submitted wouldn't work for all cases ( |
recrsn
pushed a commit
to ilatypov/node.bcrypt.js
that referenced
this pull request
Jun 1, 2020
Revert to using a deep path so that the local artifactory can host gyp binaries of different packages. A small change in node-pre-gyp will allow to use a single .npmrc variable to host binary requisites for many packages in one enterprise artifactory. mapbox/node-pre-gyp#416
|
sorry nobody reviewed this promptly @ilatypov - since enough time has passed and the code in master has changed, I'd like to ask you to re-create this PR and provide a new one if this is still needed. thanks. |
fast-facts
pushed a commit
to fast-facts/node.bcrypt.js
that referenced
this pull request
Jun 17, 2022
Revert to using a deep path so that the local artifactory can host gyp binaries of different packages. A small change in node-pre-gyp will allow to use a single .npmrc variable to host binary requisites for many packages in one enterprise artifactory. mapbox/node-pre-gyp#416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow installing a package with many dependent packages using node-pre-gyp binaries off the same local artifactory.
Avoid erasing the subpath in the mirror value.
Corrects #415 .