Update bundled Catch and fix resulting issues #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first argument to REQUIRE_THROWS and REQUIRE_THROWS_AS is documented as being an expression and recent changes mean that is now being enforced. catchorg/Catch2#823
|
Thanks. I'll wait for osmcode/libosmium#196 to be resolved before merging your changes, otherwise protozero might have the same problems on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Catch to v1.7.1 and fixed some issues resulting from catchorg/Catch2#823 by ensuring that we always pass an expression and not a block to the
REQUIRE_THROWSandREQUIRE_THROWS_ASmacros.