Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to open a tmx file with a space in the filename using AppImage with the shell #3914

Closed
Palbolsky opened this issue Mar 20, 2024 · 2 comments · Fixed by #3915
Closed

Unable to open a tmx file with a space in the filename using AppImage with the shell #3914

Palbolsky opened this issue Mar 20, 2024 · 2 comments · Fixed by #3915
Labels
bug Broken behavior.

Comments

@Palbolsky
Copy link

Describe the bug
I'm having a problem using Tiled's AppImage. I can't open a tmx file from the command line if the filename contains a space. I've tried using ", ' or even trying to escape the space with \.

To Reproduce
Steps to reproduce the behavior:

  1. Download the Tiled's AppImage
  2. Open a tmx file with a space in the name with the shell
  3. See error

Expected behavior
Tiled should open and open the file.

Media
image

Specifications:

  • OS:
    Distributor ID: Debian
    Description: Debian GNU/Linux 12 (bookworm)
    Release: 12
    Codename: bookworm

  • Tiled Version: 1.10.2
@Palbolsky Palbolsky added the bug Broken behavior. label Mar 20, 2024
@bjorn
Copy link
Member

bjorn commented Mar 20, 2024

This appears to be due to the following line, where the first parameter isn't being quoted:

tiled/dist/linux/AppRun

Line 30 in 45746fc

if [ -n ${1} ]

bjorn added a commit to bjorn/tiled-dev that referenced this issue Mar 20, 2024
@bjorn
AppImage: Fixed ability to open paths with spaces from the CLI
f715305 
The check whether the file existed was missing quotes.

Closes mapeditor#3914
@bjorn bjorn mentioned this issue Mar 20, 2024
Merged
bjorn added a commit that referenced this issue Mar 21, 2024
@bjorn
AppImage: Fixed ability to open paths with spaces from the CLI
de5373a 
The check whether the file existed was missing quotes.

Closes #3914
@AerunDev AerunDev mentioned this issue Mar 21, 2024
Closed
@bjorn
Copy link
Member

bjorn commented Apr 18, 2024 •
edited
Loading

Unfortunately the fix in de5373a has made it so that nothing launches when the AppImage is started without parameters. I'm such a noob with bash scripting... :S

bjorn added a commit to bjorn/tiled-dev that referenced this issue Apr 18, 2024
@bjorn
AppImage: Fixed ability to launch without parameters
8a70ff9 
After fixing the "is string non-empty" check in de5373a,
the script no longer did anything when no parameter was given...

As far as I could see, this check should just be removed.

See mapeditor#3914
@bjorn bjorn mentioned this issue Apr 18, 2024
Merged
bjorn added a commit to bjorn/tiled-dev that referenced this issue Apr 18, 2024
@bjorn
AppImage: Fixed ability to launch without parameters
9dcbda8 
After fixing the "is string non-empty" check in de5373a,
the script no longer did anything when no parameter was given...

As far as I could see, this check should just be removed.

See mapeditor#3914
bjorn added a commit that referenced this issue Apr 18, 2024
@bjorn
AppImage: Fixed ability to launch without parameters
4862b51 
After fixing the "is string non-empty" check in de5373a,
the script no longer did anything when no parameter was given...

As far as I could see, this check should just be removed.

See #3914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Broken behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AppImage: Fixed ability to open paths with spaces from the CLI bjorn/tiled-dev
2 participants
@bjorn @Palbolsky