Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch keyboard shortcuts for "Save As" and "Save All" #3933

Closed
differenceclouds opened this issue Apr 20, 2024 · 3 comments · Fixed by #3965
Closed

Switch keyboard shortcuts for "Save As" and "Save All" #3933

differenceclouds opened this issue Apr 20, 2024 · 3 comments · Fixed by #3965
Assignees
Labels
feature It's a feature, not a bug.

Comments

@differenceclouds
Copy link

differenceclouds commented Apr 20, 2024

(I'm on MacOS) With most other programs, Save As is command+shift+s, not command+alt+s. It's frustrating to inadvertently destroy the last saved copy of something by accident by hitting "Save All" when "Save As" was intended.

@differenceclouds differenceclouds added the feature It's a feature, not a bug. label Apr 20, 2024
@eishiya
Copy link
Contributor

eishiya commented Apr 20, 2024

You can customise the shortcuts in Edit > Preferences > Keyboard.

@bjorn
Copy link
Member

bjorn commented Apr 22, 2024

While it is true that it can be reconfigured, I wonder if it would make sense to change this shortcut. However, it would of course cause issues for some existing users.

While there must have been some applications using Ctrl+Shift+S as "Save All" (one example is Qt Creator, the IDE I use to develop Tiled), it does appear much more commonly used for "Save As" (checked Sublime Text, VS Code, Mousepad, GIMP, Inkscape, Krita and LibreOffice).

@eishiya
Copy link
Contributor

eishiya commented Apr 22, 2024

There was actually a bit of discussion about this last year on Discord, someone else complained about this exact thing, and at the time I checked the software I have:

Notepad++ has Shift for Save All and Alt for Save As, same as Tiled.
Aseprite, Photoshop, Pyxel Edit, and Krita don't have Save All, and use Shift for Save As.
Code::Blocks has Alt for Save Everything and no shortcut for Save As, how odd!

Looks like Save All isn't as common as one might expect, so it's not surprising there isn't a widely-agreed upon shortcut for it.
I guess programs go for Ctrl+Shift+S for the thing that's likely to be more commonly used in them specifically and Ctrl+Alt+S for the other thing, if they have another thing at all.

If a change is to be made, I think I'd go for Shift+Ctrl/Cmd+S for Save As, and have Save All unassigned by default. Save All seems pretty rarely needed in level-editing, and can always be assigned by those who do need it, and leaving it unassigned should avoid accidental saves (Save As is unlikely to cause problems when triggered accidentally because it pops up a dialog).

@bjorn bjorn reopened this Apr 22, 2024
@bjorn bjorn self-assigned this Jun 11, 2024
bjorn added a commit to bjorn/tiled-dev that referenced this issue Jun 14, 2024
Leaving "Save All" with no default shortcut.

Closes mapeditor#3933
@bjorn bjorn closed this as completed in bd891d6 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature It's a feature, not a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants