Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the database connection #3072

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Close the database connection #3072

merged 1 commit into from
Oct 20, 2023

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Oct 5, 2023 •
edited
Loading

Fix GEO-6793

@julianhafner
Copy link

works for me 👍

@sbrunner sbrunner requested a review from sebr72 October 5, 2023 13:07
@sbrunner sbrunner marked this pull request as ready for review October 5, 2023 13:07
sebr72
sebr72 requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed

@sebr72 sebr72 self-requested a review October 12, 2023 14:12
sebr72
sebr72 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With changes as discussed

@jwkaltz
Copy link
Contributor

jwkaltz commented Oct 17, 2023

@sebr72 @sbrunner do you what the cause of the CI error in the step "Auto reviews updates / Auto reviews updates (pull_request)" is?
Is it relevant, or can we merge?

@sebr72 sebr72 merged commit 8408732 into master Oct 20, 2023
4 checks passed
@sebr72 sebr72 deleted the close-connection branch October 20, 2023 10:38
@c2c-bot-gis-ci c2c-bot-gis-ci mentioned this pull request Oct 20, 2023
Merged
@c2c-bot-gis-ci c2c-bot-gis-ci mentioned this pull request Oct 20, 2023
Merged
@c2c-bot-gis-ci c2c-bot-gis-ci mentioned this pull request Oct 20, 2023
Merged
@c2c-bot-gis-ci c2c-bot-gis-ci mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwkaltz jwkaltz jwkaltz left review comments

@sebr72 sebr72 sebr72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sbrunner @julianhafner @jwkaltz @sebr72 @c2c-bot-gis-ci