Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor geotagging #442

Merged
merged 6 commits into from
Oct 13, 2021
Merged

refactor geotagging #442

merged 6 commits into from
Oct 13, 2021

Conversation

ptpt
Copy link
Member

@ptpt ptpt commented Oct 13, 2021 •
edited
Loading

  • generalize getagging with the GeotagFromGeneric class, which provides to_description method that returns image descriptions.
  • Move gpx_from_* to geotag/geotag_from_*
  • Remove imag_log.log_from_memory. Instead, passing image description in process_*_properties

@ptpt ptpt merged commit 0242e19 into main Oct 13, 2021
@ptpt ptpt deleted the refactor-geotag branch October 13, 2021 20:56
@ptpt ptpt mentioned this pull request Oct 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptpt @facebook-github-bot