Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple mp4 parser to replace pymp4 #506

Merged
merged 5 commits into from
Jun 27, 2022
Merged

Add a simple mp4 parser to replace pymp4 #506

merged 5 commits into from
Jun 27, 2022

Conversation

ptpt
Copy link
Member

@ptpt ptpt commented Jun 27, 2022

Why

Tests

This PR also adds test that cover the parsing (test data copied from pymp4):

python3 -m pytest -s -vv tests/unit/test_simple_mp4_parser.py

Also test against real mp4s:

# should not see any diffs
diff <(python3 -m mapillary_tools.geotag.blackvue_utils_pymp4 ~/BlackVueVideos) <(python3 -m mapillary_tools.geotag.blackvue_utils ~/BlackVueVideos)

Fixes #439

@ptpt ptpt changed the title Add a simple mp4 parser to replce pymp4 Add a simple mp4 parser to replace pymp4 Jun 27, 2022
@ptpt ptpt merged commit 65d3115 into main Jun 27, 2022
@ptpt ptpt deleted the replace-pymp4 branch June 27, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mapillary_tools upload exception pymp4 major brand string
2 participants