-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC - Restructure video processing and add gpx, nmea and exiftool runtime support #654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. This is pretty much a redo of all the geotag_*
modules but much more clear and well organized!
mapillary_tools/commands/process.py
Outdated
): | ||
vars_args["duplicate_angle"] = 360 | ||
if vars_args["geotag_sources"]: | ||
# gpx:format=A,exif:format=B -> [{source: 'gpx', 'format': 'A'}, {'source': 'exif', format': 'B'}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move all the parsing logic to process_geotag_properties.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's part of "Wire them better" in the TODO list :) but I first wanted to define the options format. We can maybe discuss it tomorrow.
… Refactoring and PR improvements.
a4a4ed6
to
e45ff97
Compare
db20813
to
c06854c
Compare
c06854c
to
fc5f0fa
Compare
This PR is a proof of concept covering video processing (
process
command applied to videos)Restructuring:
New features:
Examples:
TODO: