Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatting: Update solc, param underscores, licensing #37

Merged
merged 5 commits into from
Dec 14, 2021
Merged

formatting: Update solc, param underscores, licensing #37

merged 5 commits into from
Dec 14, 2021

Conversation

lucas-manuel
Copy link

Description

Integrations Checklist

  • Have any function signatures changed? If yes, outline below.
  • Have any features changed or been added? If yes, outline below.
  • Have any events changed or been added? If yes, outline below.
  • Has all documentation been updated?

Changelog

Function Signature Changes

Features

Events

@lucas-manuel lucas-manuel self-assigned this Dec 14, 2021
deluca-mike
deluca-mike suggested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@deluca-mike deluca-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing _getImplementationOfProxy. Proxy in Readme is outdated.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
deluca-mike
deluca-mike suggested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@deluca-mike deluca-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contract Proxy is SlotManipulatable. is still incorrect/outdated in the readme.

@lucas-manuel lucas-manuel merged commit 1462860 into main Dec 14, 2021
@lucas-manuel lucas-manuel deleted the final-formatting branch December 14, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deluca-mike deluca-mike deluca-mike approved these changes

@JGcarv JGcarv Awaiting requested review from JGcarv

Assignees

@lucas-manuel lucas-manuel

Labels
Priority: High Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-manuel @deluca-mike