chore: Natspec, checksums, whitespace, cleanup #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #4465: Update natspec, whitespace, checksums (after taking latest release submodules) for all repos. |
deluca-mike
force-pushed
the
sc-4465-update-natspec-whitespace-checksums-after
branch
2 times, most recently
from
e6f18a0 to
59f767c
Compare
deluca-mike
force-pushed
the
sc-4465-update-natspec-whitespace-checksums-after
branch
from
59f767c to
032d37f
Compare
| /// @title An implementation that is to be proxied, must extend Proxied. | ||
| contract Proxied is SlotManipulatable { | ||
| /// @title An implementation that is to be proxied, will need ProxiedInternals. | ||
| abstract contract ProxiedInternals is SlotManipulatable { |
| @@ -6,23 +6,23 @@ import { IProxied } from "./interfaces/IProxied.sol"; | |||
| import { Proxy } from "./Proxy.sol"; | |||
|
|
|||
| /// @title A factory for Proxy contracts that proxy Proxied implementations. | |||
| contract ProxyFactory { | |||
| abstract contract ProxyFactory { | |||
There was a problem hiding this comment.
Why is this abstract? We don't have any unimplemented functions
| @@ -1,7 +1,7 @@ | |||
| // SPDX-License-Identifier: AGPL-3.0-only | |||
| pragma solidity ^0.8.7; | |||
|
|
|||
| contract SlotManipulatable { | |||
| abstract contract SlotManipulatable { | |||
lucas-manuel
changed the title
lucas-manuel
approved these changes
Dec 24, 2021
lucas-manuel
deleted the
sc-4465-update-natspec-whitespace-checksums-after
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrations Checklist
Changelog
Function Signature Changes
Features
Events