-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Migrate to Maplibre #2
Comments
Hi @m0nac0 , I have all the setup to build on macOS, but i'm just not used to all of this and mapbox-gl in general. If you think you can guide a bit through, I can test some things for you. Just tell me ! |
Amazing! I'll be happy to help as much as possible, but I don't know much about iOS development either 😂 You can take a look at the m0-ios-extension branch. (Most important commits are 0961470 and 4e617e5) This plugin directly referenced the Mapbox iOS SDK, which I changed to use the Maplibre iOS SDK. But the plugin also referenced the Mapbox iOS Annotation extension, which in turn also references the Mapbox iOS SDK. So I forked the Annotation extension (https://github.com/m0nac0/maplibre-annotation-extension) and modified it to also use the Maplibre SDK. Then I modified this plugin to use my fork of the annotation extension. But when I now try to compile the example app I get this error (because of the annotation extension):
If I replace So I think the best way to start would be opening both projects (this repo and the forked annotation extension) in Xcode and try:
Let me know if you have more questions, I'm not sure how good my explanation was ;) |
Oh, I didn't see your response... I could try something on some off day, but I really don't know when I could try this ahah I'll report here when I can watch it 😁 |
I was able to compile for iOS. Changes have to be made in maplibre-cocoapods, maplibre-annotation-extension and here in flutter-maplibre-gl. Due to dependant references it makes sense to apply changes one after the other. I opened m0nac0/maplibre-cocoapods#1 for the cocoapods changes and m0nac0/maplibre-annotation-extension#1 for annotation extension changes. These currently still link to my fork and should be changed after the cocoapods PR merge. |
@m0nac0 did you find some time to look at the open PRs? |
@mindthefish Amazing work, I finally noticed the activity in this repo! I'm so sorry for missing it for such a long time. I merged your three PRs. We can still update the reference in the annotation extension, what else has to be done? |
I am also just trying to get back into the project. 😆 |
#9 is merged and this library should now work on iOS. 🎉 Thank you @mindthefish ! Please open new issues if you find any bugs! |
Currently, I've gotten the plugin to compile on iOS, but it still uses Mapbox GL Native, not Maplibre GL Native.
I most likely won't be able to perform this migration, so any help/contributions are very welcome!
The text was updated successfully, but these errors were encountered: