Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide logo on Android/iOS to match web #101

Merged
merged 3 commits into from
May 24, 2022
Merged

hide logo on Android/iOS to match web #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abea63b
hide logo on iOS/Android to match web
m0nac0 May 24, 2022
a2e34e6
update android maplibre dependency
m0nac0 May 24, 2022
f370023
make AttributionButtonPosition.BottomRight the default
m0nac0 May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ android {
targetCompatibility JavaVersion.VERSION_1_8
}
dependencies {
implementation 'org.maplibre.gl:android-sdk:9.5.1'
implementation 'org.maplibre.gl:android-sdk:9.5.2'
implementation 'org.maplibre.gl:android-plugin-annotation-v9:1.0.0'
implementation 'org.maplibre.gl:android-plugin-localization-v9:1.0.0'
implementation 'org.maplibre.gl:android-plugin-offline-v9:1.0.0'
Expand Down
3 changes: 2 additions & 1 deletion android/src/main/java/com/mapbox/mapboxgl/MapboxMapBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
class MapboxMapBuilder implements MapboxMapOptionsSink {
public final String TAG = getClass().getSimpleName();
private final MapboxMapOptions options = new MapboxMapOptions()
.attributionEnabled(true);
.attributionEnabled(true)
.logoEnabled(false);
private boolean trackCameraPosition = false;
private boolean myLocationEnabled = false;
private int myLocationTrackingMode = 0;
Expand Down
1 change: 1 addition & 0 deletions ios/Classes/MapboxMapController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ class MapboxMapController: NSObject, FlutterPlatformView, MGLMapViewDelegate, Ma
) {
mapView = MGLMapView(frame: frame)
mapView.autoresizingMask = [.flexibleWidth, .flexibleHeight]
mapView.logoView.isHidden = true
self.registrar = registrar

super.init()
Expand Down
2 changes: 1 addition & 1 deletion lib/src/mapbox_map.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class MaplibreMap extends StatefulWidget {
this.logoViewMargins,
this.compassViewPosition,
this.compassViewMargins,
this.attributionButtonPosition,
this.attributionButtonPosition = AttributionButtonPosition.BottomRight,
this.attributionButtonMargins,
this.onMapClick,
this.onUserLocationUpdated,
Expand Down