Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podspecs in correct Cocoapods layout #128

Merged
merged 10 commits into from
Jul 27, 2022

Conversation

kuhnroyal
Copy link
Collaborator

Follow up to my comments in #91

I tried this with a private repo and it works well.
Alternatively you could create some https://github.com/m0nac0/flutter-maplibre-specs repo for this.

Build will fail until this is available in the default branch of either repository.

@kuhnroyal
Copy link
Collaborator Author

@m0nac0 My tests with this Spec repo layout were successful. Everything in this PR works, just need a place to store the specs in the correct layout. Makes everything much easier.

You can test it locally with this repo: https://github.com/source-kitchen/flutter-maplibre-podspecs
You can clone this and use it as starting point for a new repo, don't fork as I plan to remove it ASAP.

@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 18, 2022

@kuhnroyal I've created https://github.com/m0nac0/flutter-maplibre-podspecs. Would you like to adapt this PR?

@kuhnroyal kuhnroyal marked this pull request as ready for review July 18, 2022 11:16
@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 18, 2022

Not sure why the CI is failing

@kuhnroyal
Copy link
Collaborator Author

Yea me neither, I updated the example Podfile.lock and XCode files, hope that helps. The Podfile.lock should be committed to Git.

README.md Outdated Show resolved Hide resolved
@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 18, 2022

Can you try re-adding the pod update step in the CI to check if that's the issue?

And when you tested this yourself, did you test with the example app or your own project?

@kuhnroyal
Copy link
Collaborator Author

It runs locally, so I am not sure, will try.

@kuhnroyal
Copy link
Collaborator Author

Not sure why, don't need that locally for the example or my own app.

@kuhnroyal
Copy link
Collaborator Author

The pod update was not needed, the problem was related to some Podfile miss configuration for the simulator target.

@kuhnroyal
Copy link
Collaborator Author

This should be fine now and can be squashed probably.

@kuhnroyal kuhnroyal changed the title Proof of concept: Add podspecs in correct Cocoapods layout Add podspecs in correct Cocoapods layout Jul 18, 2022
@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 21, 2022

I added one small request, otherwise this looks good.

@kuhnroyal
Copy link
Collaborator Author

I added one small request, otherwise this looks good.

Can't see it :)

README.md Outdated Show resolved Hide resolved
example/ios/Podfile Outdated Show resolved Hide resolved
@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 27, 2022

Sorry, I left the comment as "pending" review and missed your reply. It should be visible now?

Co-authored-by: m0nac0 <58807793+m0nac0@users.noreply.github.com>
@kuhnroyal
Copy link
Collaborator Author

Done

Copy link
Collaborator

@m0nac0 m0nac0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing: do we need example/pubspec.yaml to be committed to the repo or is this just an artifact of the change to .gitignore?

@kuhnroyal
Copy link
Collaborator Author

One more thing: do we need example/pubspec.yaml to be committed to the repo or is this just an artifact of the change to .gitignore?

I would always commit the pubspec.lock for apps because this prevents accidental breakage, especially in CI.
For libraries this is not recommended but I believe for apps this is the correct way.

@m0nac0 m0nac0 merged commit a33ae7e into maplibre:main Jul 27, 2022
@m0nac0
Copy link
Collaborator

m0nac0 commented Jul 27, 2022

@kuhnroyal Thanks again for your patience!

@kuhnroyal kuhnroyal deleted the feature/podspecs branch May 15, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants