-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podspecs in correct Cocoapods layout #128
Conversation
@m0nac0 My tests with this Spec repo layout were successful. Everything in this PR works, just need a place to store the specs in the correct layout. Makes everything much easier. You can test it locally with this repo: https://github.com/source-kitchen/flutter-maplibre-podspecs |
@kuhnroyal I've created https://github.com/m0nac0/flutter-maplibre-podspecs. Would you like to adapt this PR? |
43b9ee5
to
05eb1ee
Compare
05eb1ee
to
3ac1042
Compare
Not sure why the CI is failing |
Yea me neither, I updated the example |
Can you try re-adding the And when you tested this yourself, did you test with the example app or your own project? |
It runs locally, so I am not sure, will try. |
Not sure why, don't need that locally for the example or my own app. |
9bc8e01
to
31e3def
Compare
31e3def
to
0656ca1
Compare
The |
This should be fine now and can be squashed probably. |
I added one small request, otherwise this looks good. |
Can't see it :) |
Sorry, I left the comment as "pending" review and missed your reply. It should be visible now? |
Co-authored-by: m0nac0 <58807793+m0nac0@users.noreply.github.com>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing: do we need example/pubspec.yaml to be committed to the repo or is this just an artifact of the change to .gitignore?
I would always commit the |
@kuhnroyal Thanks again for your patience! |
Follow up to my comments in #91
I tried this with a private repo and it works well.
Alternatively you could create some
https://github.com/m0nac0/flutter-maplibre-specs
repo for this.Build will fail until this is available in the default branch of either repository.