Added getSourceIds to the controller #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0nac0
reviewed
Feb 23, 2023
m0nac0
reviewed
Feb 23, 2023
|
the requested changes are done like you asked @m0nac0 |
|
Sorry for noticing only now: could you add a button somewhere in the example app using this new function? That way we could manually test it (now and in the future) |
|
Yes, I was hesitant to do this when adding the feature so i'll do it later today Edit: tomorrow |
|
I added a page with get layer ids and get source ids |
|
Great thanks! I enabled auto-merge, if you could again update with the latest changes from main it should merge automatically. (Btw, I was able to confirm it works on iOS) |
stevehayles
added a commit
to stevehayles/flutter-maplibre-gl
that referenced
this pull request
Apr 26, 2023
Added getSourceIds to the controller with the android (tested) and ios (no ability to test here sorry). Not implemented on the web as getLayerIds in not implemented too I made the controller method returning a list of strings (`Future<List<String>>`) to have an explicit `String` list unlike `getLayerIds` who have a `Future<List<dynamic>>`
JanikoNaber
pushed a commit
to JanikoNaber/flutter-maplibre-gl
that referenced
this pull request
Aug 23, 2023
Added getSourceIds to the controller with the android (tested) and ios (no ability to test here sorry). Not implemented on the web as getLayerIds in not implemented too I made the controller method returning a list of strings (`Future<List<String>>`) to have an explicit `String` list unlike `getLayerIds` who have a `Future<List<dynamic>>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added getSourceIds to the controller with the android (tested) and ios (no ability to test here sorry). Not implemented on the web as getLayerIds in not implemented too
I made the controller method returning a list of strings (
Future<List<String>>) to have an explicitStringlist unlikegetLayerIdswho have aFuture<List<dynamic>>