-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use separate scheduled pipeline for Flutter beta builds #28
Conversation
* build PRs and main with fixed stable version to improve build times
@kuhnroyal Just to make sure, you intended this to still be a draft, right? |
This is just an idea, if you think this is a possible solution for now then I can mark it ready. Maybe you can re-run the check a couple times. |
Ah, I see. I get the split between stable flutter for PRs and beta flutter on a cron job. But I don't understand why this would improve run times. What is being cached? |
Well the hope is for |
Ah interesting, was the flutter action updated to support this? I thought it wasn't supported because subosito/flutter-action#16 is still open... |
I see, I mostly use private runners which behave differently here. So this might not work at all :( Still think we should run the main CI flow on stable and have a cron trigger for beta. |
Yeah I agree about having these two separate CI workflows. I've added caching of flutter as a test. For macos this is a noticeable speedup in my experience, ubuntu remains to be seen. The dilemma here was previously: in the cache-key you need to specify the flutter version, otherwise you could never update flutter, because the old flutter version would always be restored from cache. But there is no (easy) API for retrieving the latest flutter version on a channel. So if you wanted to just use a flutter channel (and not a specific version), you'd first need to always install flutter to find out the latest version. At that point, caching is useless. If we pin the flutter version, this is not a problem, anymore. |
Sounds good, should probably set it to |
Simple approach but should be enough for now.
Hope the caching works with
2.5.x
.This should also speed up the single steps by a lot.