Fix example app pubspec #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These previously weren't an issue because they were always overridden below. But now we want to comment out these override to actually show people how to use the plugin. ref maplibre#322
JulianBissekkou
approved these changes
Nov 14, 2023
|
Thanks for taking care of all these open issues. We are currently a little restricted with the time we have for contributions to maplibre so I am very thankful for the work you do |
|
I know that kind of situation very well, thank you for still investing the time for reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports changes I already did for the last release to the main branch.
Closes #322