Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tracking mode conversion in onCameraTrackingChanged #376

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

XanderD99
Copy link
Contributor

fix for #375

just a fast fix to map the mode to the flutter enum values.

@m0nac0
Copy link
Collaborator

m0nac0 commented Mar 3, 2024

Thanks for contributing, and sorry you had to wait for feedback on this!
Do you know if iOS works fine? Looking at the docs at https://maplibre.org/maplibre-native/ios/api/Enums/MGLUserTrackingMode.html#/MGLUserTrackingMode it seems that the iOS and Flutter constant values for the enums should be the same, but it would be good to know should you have already testet it (no worries if you don't know).

@XanderD99
Copy link
Contributor Author

Yeah iOS seems to be working fine they use basically the same types like the flutter package. Android does like you said use different types and enum values

@m0nac0 m0nac0 merged commit 1ec44fe into maplibre:main Mar 3, 2024
6 checks passed
@josxha josxha added this to the v0.19.0 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants