-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flutter_lints
, fix or ignore lints
#414
Conversation
flutter_lints
, fix or ignore lints
I am not sure if all the changes are supported on the minimum SDK, ( I created #416 to ensure that we always build the min SDK and stable. Or you can pick those changes into this branch. |
It got added 2 years ago, so I'm about certain it is supported. flutter/flutter#111619
Fixing all those doc strings took too much time so that I'd rather do it not again. I cherry picked your updated CI into a new branch that is based on this. https://github.com/josxha/flutter-maplibre-gl/actions/runs/9132300475 Resolving dependencies...
The current Dart SDK version is 3.0.5.
Because maplibre_gl_example depends on flutter_lints >=3.0.2 which requires SDK version >=3.1.0 <4.0.0, version solving failed.
The Flutter CLI developer tool uses Google Analytics to report usage and diagnostic data
along with package dependencies, and crash reporting to send basic crash reports.
This data is used to help improve the Dart platform, Flutter framework, and related tools. flutter_lints version 4 requires at least dart version 3.2.0. |
After I bumped the flutter version to 3.16.0, all jobs succeed. |
Nice, so this is fine.
Lets just use |
I used Compiling lib/main.dart for the Web...
Target dart2js failed: Exception: lib/sources.dart:352:3[9](https://github.com/josxha/flutter-maplibre-gl/actions/runs/9134655373/job/25120633165#step:5:10):
Error: Couldn't find constructor 'TextScaler.linear'.
textScaler: const TextScaler.linear(1.4),
^^^^^^
lib/sources.dart:352:21:
Error: No named parameter with the name 'textScaler'.
textScaler: const TextScaler.linear(1.4),
^^^^^^^^^^
/opt/hostedtoolcache/flutter/stable-3.[10](https://github.com/josxha/flutter-maplibre-gl/actions/runs/9134655373/job/25120633165#step:5:11).5-x64/packages/flutter/lib/src/widgets/text.dart:428:9:
Info: Found this candidate, but the arguments don't match.
const Text(
^^^^
Error: Compilation failed. |
* ensure examples are being built on minimum supported SDK and latest stable SDK * remove automatic formatter workflow, we ensure correct formatting on every PR and since formatting is Dart version dependent, this might not always work * remove formatting/analyze steps from beta CI - same as above formatting and analysis should always use latest stable as baseline
I picked the CI update into this branch and replaced the |
commit f27bcab Author: Joscha <34318751+josxha@users.noreply.github.com> Date: Sat May 18 23:49:28 2024 +0200 feat: allow latest `flutter_lints` version (maplibre#419) commit 8323f55 Author: Joscha <34318751+josxha@users.noreply.github.com> Date: Sat May 18 02:00:56 2024 +0200 feat: add `flutter_lints`, fix or ignore lints (maplibre#414) Co-authored-by: Peter Leibiger <kuhnroyal@gmail.com> commit e5d95ed Author: Joscha <34318751+josxha@users.noreply.github.com> Date: Fri May 17 23:38:40 2024 +0200 fix(web): ensure the usage of `maplibre-gl-js` version 4.x.x, remove `_addStylesheetToShadowRoot` (maplibre#409) commit e617b90 Author: Joscha <34318751+josxha@users.noreply.github.com> Date: Fri May 17 16:33:47 2024 +0200 feat: update package links in pubspec.yaml files (maplibre#413) commit 68040d4 Author: Joscha <34318751+josxha@users.noreply.github.com> Date: Fri May 17 16:25:36 2024 +0200 chore: delete `pubspec.lock` files (maplibre#412) commit 3db5b2a Author: Fabian Keunecke <github@fabiankeunecke.de> Date: Fri May 17 14:58:33 2024 +0200 Support newer Gradle versions (maplibre#390) commit 7cb6521 Author: Joscha <34318751+josxha@users.noreply.github.com> Date: Fri May 17 14:53:47 2024 +0200 feat(web): allow package:js version 0.6.x and 0.7.x (maplibre#410)
Co-authored-by: Peter Leibiger <kuhnroyal@gmail.com>
Co-authored-by: Peter Leibiger <kuhnroyal@gmail.com>
Co-authored-by: Peter Leibiger <kuhnroyal@gmail.com>
Still a couple hundered changed lines but I hope that it's now better reviewable. If not, I separated the changes into different commits.
See the commit history for more details on the changes.