feat: use lints from very_good_analysis #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhnroyal
approved these changes
Jun 2, 2024
Remi-deronzier
pushed a commit
to viamichelin/flutter-maplibre-gl
that referenced
this pull request
Sep 6, 2024
This pull request swaps out the basic flutter_lints ruleset for a more strict one, in this case the one from very_good_analysis because it gets used often in other projects and is well maintained. I made it that all packages reference the same lint file with the option to change the behavior for some if needed. - very_good_analysis has the same lower sdk bound as we, so it matches quite well. - I added all the lints to be ignored temporarily. Most of them are code smells, the use of dynamic typing, undocumented code or hints where code can be refactored to be more clean in general.
Remi-deronzier
pushed a commit
to viamichelin/flutter-maplibre-gl
that referenced
this pull request
Sep 10, 2024
This pull request swaps out the basic flutter_lints ruleset for a more strict one, in this case the one from very_good_analysis because it gets used often in other projects and is well maintained. I made it that all packages reference the same lint file with the option to change the behavior for some if needed. - very_good_analysis has the same lower sdk bound as we, so it matches quite well. - I added all the lints to be ignored temporarily. Most of them are code smells, the use of dynamic typing, undocumented code or hints where code can be refactored to be more clean in general.
Remi-deronzier
pushed a commit
to viamichelin/flutter-maplibre-gl
that referenced
this pull request
Sep 10, 2024
This pull request swaps out the basic flutter_lints ruleset for a more strict one, in this case the one from very_good_analysis because it gets used often in other projects and is well maintained. I made it that all packages reference the same lint file with the option to change the behavior for some if needed. - very_good_analysis has the same lower sdk bound as we, so it matches quite well. - I added all the lints to be ignored temporarily. Most of them are code smells, the use of dynamic typing, undocumented code or hints where code can be refactored to be more clean in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request swaps out the basic flutter_lints ruleset for a more strict one, in this case the one from very_good_analysis because it gets used often in other projects and is well maintained.
I made it that all packages reference the same lint file with the option to change the behavior for some if needed.