Merge tobrun 0.12 #8
Conversation
* Change SDK version of example * Add toScreenLocationBatch * Add custom marker example
…click area management) (#575) * AnnotationClickOrder working (not order but activation/desactivation) * Switch to annotationConsumeTapEvents method
When a download error occurs, the app is informed through the channel so that it can display an appropriate error. However, on subsequent calls to list the available downloaded packs it is surprising to see that the failed region download is present as if it had been downloaded. There is no way for the app to repair this incomplete pack. Therefore, it seems much better to clean up the failed download as soon as it's detected. If any tiles were downloaded they will be at least temporarily in the cache and available to a future re-download attempt. This follows the same logic as failures caused by hitting the tile limit.
…576) * added batch mode * added circle support * added remove features * removed test code * inital android implementation * added documentation * removed unused code * add batch example
* Update to Mapbox-iOS-SDK 6.3.0 The 6.0.0 upgrade had no breaking changes: > This major release does not include any breaking changes to public > APIs. We are treating this release as a SEMVER major change because > our installation instructions have changed. https://github.com/mapbox/mapbox-gl-native-ios/releases/tag/ios-v6.0.0 I did however need to cast the `accessToken` as a `String` to satisfy the compiler after this upgrade. Prior to the upgrade I was seeing crashes from this bug, which was fixed in 6.2: mapbox/mapbox-gl-native-ios#485 So far I don't see any issues at all after the upgrade. Developers will need to configure their access token in order to fetch the mapbox sdk for this an future versions, described here: https://docs.mapbox.com/ios/maps/guides/install/ * Setup .netrc for iOS mapbox sdk download Writes a `~/.netrc` file containing the credentials needed to download the iOS mapbox sdk. I'm not experienced with github workflow so I'm just hoping that I can write to the home directory of whatever container it runs in. This should allow curl to find and use the given credentials. Co-authored-by: tobrun <tobrun.van.nuland@gmail.com>
|
@vberthet Thank you for contributing! I've started to review the changes, but since they are pretty extensive I'll need a bit more time to work through them. |
|
@vberthet Sorry for taking so awfully long with this and again thanks for opening the PR. I left some comments and have worked through most of the changes, just some of the iOS stuff left to work through... |
|
@vberthet I've solved the merge conflicts locally, if you'd like me to push the merge commit you'd need to edit the settings for the PR to allow me that. (https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) If you'd rather do it yourself that is also fine, though! |
|
@vberthet I finally finished the review! As soon as the merge conflict is resolved, I'd love to merge this! I could just address the remaining comments regarding the changelogs after this PR is merged. |
|
@m0nac0 I've updated the CHANGELOG files |
Merge change from https://github.com/tobrun/flutter-mapbox-gl/tree/0.12.0
It also include iso build fix from #7