Fix typo in generateInspectStyle
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to date back to `mapbox-gl-inspect`, and prevented the `forEach(sourceId)` loop from actually doing anything. Typo introduced here: lukasmartinelli/mapbox-gl-inspect@6bbe984
acalcutt
reviewed
Feb 7, 2023
|
Code wise this makes sense to me. Do you have a screenshot of what this actually changes? |
|
I don't, the issue that led me to this was actually entirely unrelated (a misconfiguration on my part). My understanding is that if you have a style mixing raster and vector sources (which I do not), this loop intends to hide the rasters from the inspect view |
|
I did a bit of looking to understand the code and it seems like this eventually gets sent to maplibre SetStyle. I agree this is a typo, since 'soources' would be of no use to SetStyle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny typo I noticed while tracing through the code in the debugger.
Seems to date back to
mapbox-gl-inspect, and prevented theforEach(sourceId)loop from actually doing anything.Typo introduced here: lukasmartinelli/mapbox-gl-inspect@6bbe984