Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Fog in Vertical Perspective with Terrain #4985

Open
birkskyum opened this issue Nov 4, 2024 · 1 comment
Open

Support Fog in Vertical Perspective with Terrain #4985

birkskyum opened this issue Nov 4, 2024 · 1 comment
Assignees
@ibesora
Labels
enhancement New feature or request fog / horizon globe Globe related issues terrain vertical-perspective Vertical Perspective projection
Milestone
5.0

Comments

@birkskyum
Copy link
Member

Currently the Fog isn't Supported in the Globe projection with Terrain3D

maplibre-gl-js/src/geo/projection/globe_transform.ts

Line 682 in 6eeafe9

warnOnce('calculateFogMatrix is not supported on globe projection.');

@birkskyum birkskyum added enhancement New feature or request globe Globe related issues terrain labels Nov 4, 2024
@birkskyum birkskyum mentioned this issue Nov 4, 2024
Merged
@birkskyum birkskyum mentioned this issue Nov 4, 2024
Closed
8 tasks
@birkskyum birkskyum changed the title Support Fog on Globe with Terrain3D Support Fog on Globe with Terrain Nov 4, 2024
@birkskyum birkskyum added this to the 5.0 milestone Nov 5, 2024
@ibesora ibesora self-assigned this Nov 6, 2024
@birkskyum birkskyum changed the title Support Fog on Globe with Terrain Support Fog in Vertical Perspective with Terrain Nov 9, 2024
@birkskyum birkskyum added vertical-perspective Vertical Perspective projection globe Globe related issues and removed globe Globe related issues labels Nov 9, 2024
This was referenced Nov 17, 2024
Closed
Open
@birkskyum
Copy link
Member Author

The crashes related to globe fog are interfering with ongoing work on projection expressions

Screen.Recording.2024-11-17.at.14.39.52.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibesora ibesora

Labels
enhancement New feature or request fog / horizon globe Globe related issues terrain vertical-perspective Vertical Perspective projection
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

Fix terrain fog on globe ibesora/maplibre-gl-js
2 participants
@ibesora @birkskyum