Projection expressions

[birkskyum]

Blocked by / How to use

• Add projection expression syntax maplibre-style-spec#888
• Add projection expression syntax (#888) maplibre-style-spec#899
• Refactor usage of implicit parameter to an explicit one when rendering #5020

Closes #5039

• Feature parity "interpolate" expressions for projectionDefinition #5039

interpolate example

const exprestInt = createExpression(['interpolate', ['linear'], ['zoom'], 10, 'vertical-perspective', 12, 'mercator'], v8.projection.type)

Screen.Recording.2024-11-13.at.01.28.44.mov

step example

const exprestInt = createExpression(['step', ['zoom'], 'vertical-perspective', 12, 'mercator'], v8.projection.type)

Screen.Recording.2024-11-13.at.01.50.51.mov

Launch Checklist

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Add an entry to CHANGELOG.md under the ## main section.

[HarelM]

Remove globe-mercator?

[HarelM]

I was expecting the code here to use the expression value of projection, is it using the expression value somewhere that I have missed?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.27%. Comparing base (8555091) to head (63b317f).
Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
src/style/style.ts	63.63%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5040      +/-   ##
==========================================
+ Coverage   89.25%   89.27%   +0.02%     
==========================================
  Files         269      269              
  Lines       38286    38330      +44     
  Branches     2347     2427      +80     
==========================================
+ Hits        34172    34220      +48     
- Misses       3117     3130      +13     
+ Partials      997      980      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[birkskyum]

@HarelM , there is some preparation work needed in GL JS before this can be hooked up to the map style.

I think the best take on it is to make this PR just an "'update style-spec", allowing the createExpression to work. Then we can refactor incrementally on the main branch, until we can hook it up to the map.style, and only then make the changelog item for the new feature. Do you think that can work?

For example, I see some issues with tile loading, when going between projections:

Screen.Recording.2024-11-17.at.14.38.39.mov

And if terrain is enabled, the globe/vertical-perspective fog appear to break things.

• Support Fog in Vertical Perspective with Terrain #4985
• Fix terrain fog on globe #4924

Screen.Recording.2024-11-17.at.14.39.52.mov

Also, the vertical-perspective projection, in the setProjection, it doesn't take a globeness value that we can use to pass in the transition.

Also there could be some perf here, where we maybe should update the globeness in the existing projection instance, instead of making a lot of new Projection instances.

[HarelM]

Spec package will be updated automatically in a few days by dependabot.
If there are other changes related to this package update then it should be part of this PR I guess.
Other existing bugs not related to the sec change should be handled regardless of this change.

[birkskyum]

Sounds good, I'll leave it to dependabot to make the version change (thought it didn't handled major-release updates).