Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing style-spec typings to publish #1470

Merged
merged 2 commits into from
Aug 13, 2022

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Aug 12, 2022

Launch Checklist

Related to #1107 #1116 #1468
This basically adds the missing step in the publish CI script which I assumed happens automatically but apparently it was a wrong assumption as the only thing that runs in the post install is the code generation that is needed in order to build the package but the type generation is not part of it.
My bad :-(

@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2022

Bundle size report:

Size Change: 0 B
Total Size Before: 203 kB
Total Size After: 203 kB

Output file Before After Change
maplibre-gl.js 193 kB 193 kB 0 B
maplibre-gl.css 9.65 kB 9.65 kB 0 B
ℹ️ View Details No major changes

Copy link
Contributor

@wipfli wipfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks @HarelM for fixing this! Please update the lockfile

src/style-spec/package.json Show resolved Hide resolved
src/style-spec/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Oliver Wipfli <oliver.wipfli@leichteralsluft.ch>
@wipfli wipfli merged commit bb9fb0d into main Aug 13, 2022
@wipfli wipfli deleted the add-missing-style-spec-typings branch August 13, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants