Fix/improve expression type #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix step typing. Simplify +, concat, coalesce typings.
|
Bundle size report: Size Change: 0 B
ℹ️ View DetailsNo major changes |
HarelM
reviewed
Aug 17, 2022
HarelM
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes interpolate typing: allow number arrays, but no expressions (see #1380 (comment))
Also fixes interpolate-hcl/interpolate-lab.
Fix step typing (same as #1509)
Simplify +, concat, coalesce typings (like done for the interpolate types)
Separates tests for expressions per se and tests for expressions with injected constants.
In most cases this would require typing the constant due to typescript inferring rather broad types, but for some simple cases it is possible.