Rename css

[HarelM]

Launch Checklist

Resolved #83

• confirm your changes do not include backports from Mapbox projects (unless with compliant license)
• briefly describe the changes in this PR
• include before/after visuals or gifs if this PR includes visual changes
• write tests for all new functionality
• document any changes to public APIs
• post benchmark scores
• manually test the debug page
• apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
• add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>

[github-actions]

Bundle size report:

Size Change: +10 B
Total Size Before: 205 kB
Total Size After: 205 kB

Output file	Before	After	Change
maplibre-gl.js	196 kB	196 kB	-3 B
maplibre-gl.css	8.86 kB	8.87 kB	+13 B

ℹ️ View Details

Source file	Before	After	Change
src/ui/map.js	6.26 kB	6.27 kB	+8 B
src/ui/handler/box_zoom.js	799 B	802 B	+3 B
src/ui/control/attribution_control.js	1.27 kB	1.28 kB	+3 B
src/ui/control/geolocate_control.js	2.23 kB	2.23 kB	+3 B
src/ui/control/navigation_control.js	1.69 kB	1.69 kB	+2 B
src/ui/anchor.js	202 B	204 B	+2 B
src/ui/control/scale_control.js	694 B	695 B	+1 B
src/ui/handler/shim/drag_pan.js	232 B	233 B	+1 B
src/ui/handler/shim/touch_zoom_rotate.js	301 B	302 B	+1 B
src/ui/marker.js	2.82 kB	2.82 kB	+1 B
src/ui/popup.js	1.83 kB	1.83 kB	+1 B
src/util/mapbox.js	3.07 kB	3.06 kB	-3 B
src/util/util.js	2.48 kB	2.47 kB	-4 B

[wipfli]

Are the tests failing for good or do we have problems again?

[HarelM]

I think they are blinking unfortunately...
But some did fail due to bugs I introduced.
In any case, I think I managed to fix everything...
I couldn't find a way to rerun tests without pushing another commit...?

[wipfli]

Go to https://github.com/maplibre/maplibre-gl-js/pull/185/checks then click here:

[HarelM]

I probably don't have this right permissions as I didn't see this button when I tried to find out how to rerun...

[HarelM]

My mistake, I do have this button.

[wipfli]

#83

[wipfli]

Thanks for working on this Harel. If the updated css means that users have to do some find-and-replace, can you maybe add a note about this in the README?

[HarelM]

Sure, no problem.
Should this be version 2.0 then due to this breaking change or 1.15 is enough?

[wipfli]

That's a good question. You know when we went from the release candidates of version 1.13 to the actual release v1.14 we also broke stuff by using maplibre rather than mapbox.

[HarelM]

Yea, I know, that's why I suggested 1.15.
I'm good with 1.15.

[HarelM]

@wipfli can you please review so this will be ready for merge? Currently merge is blocked due to required code review.

[wipfli]

Thanks Harel

[bendman]

Will the policy of this repo be to use minor version bumps in the future to denote breaking changes, or will it eventually change to use semver major bumps?

[HarelM]

I think the place for such a question is the discussions area as this was merged and released. I honestly not sure what you are asking or what are you suggesting... :-)