Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note on pseudo fullscreen mode on iOS #3311

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Add note on pseudo fullscreen mode on iOS #3311

merged 2 commits into from
Nov 3, 2023

Conversation

jhemmje
Copy link
Contributor

@jhemmje jhemmje commented Nov 3, 2023 •
edited by HarelM
Loading

Description

Fixes #3306

In the issue #3306 I discovered and described that the fullscreen mode example does not work on iOS because an iframe is used which prevents the map from scaling. I have therefore extended the description of this example accordingly.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Add an entry to CHANGELOG.md under the ## main section.

@jhemmje jhemmje marked this pull request as ready for review November 3, 2023 11:07
@jhemmje jhemmje mentioned this pull request Nov 3, 2023
Closed
HarelM
HarelM approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!!

@HarelM HarelM enabled auto-merge (squash) November 3, 2023 11:14
@jhemmje
Copy link
Contributor Author

jhemmje commented Nov 3, 2023

@HarelM
Thanks for approving!
Do you know what to do with the failed test? This is my first PR in this repo, so unfortunately I'm not familiar with the tests.

@HarelM
Copy link
Collaborator

HarelM commented Nov 3, 2023

Flaky tests, running again now...

@HarelM HarelM merged commit 7519ac9 into maplibre:main Nov 3, 2023
14 checks passed
@jhemmje jhemmje deleted the patch-1 branch November 3, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fullscreen mode does not work on Safari Mobile on iOS
2 participants
@jhemmje @HarelM