-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set terrain from diff #3515
Set terrain from diff #3515
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3515 +/- ##
==========================================
+ Coverage 85.88% 85.90% +0.02%
==========================================
Files 244 244
Lines 48174 48213 +39
Branches 5126 5147 +21
==========================================
+ Hits 41374 41418 +44
+ Misses 6800 6795 -5 ☔ View full report in Codecov by Sentry. |
The 3 missing lines in the coverage report are related to a situation where the diffStyle function from the style spec package returns a different operation than expected. This is now ready for review. |
Launch Checklist
Fixes #3463 - add support for terrain in diff
diff:true
and terrain change the map doesn't change #3463This depends on the following PR to be merged and published first:
Also added some types to
pick
method.CHANGELOG.md
under the## main
section.