Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test opacity of a partly visible marker #3644

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

sbachinin
Copy link
Collaborator

Concludes #3458

@HarelM
Copy link
Collaborator

HarelM commented Jan 29, 2024

For some reason codecov didn't send a message, can you make sure the line is now fully covered?

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e28671) 86.61% compared to head (ef6fed0) 86.94%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3644      +/-   ##
==========================================
+ Coverage   86.61%   86.94%   +0.32%     
==========================================
  Files         240      240              
  Lines       32214    32214              
  Branches     2132     2116      -16     
==========================================
+ Hits        27903    28007     +104     
+ Misses       3356     3258      -98     
+ Partials      955      949       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbachinin
Copy link
Collaborator Author

From my understanding, this line is now ok. There are test cases that reach this line and execute both truthy and falsy part

@HarelM HarelM merged commit 10f0104 into maplibre:main Jan 29, 2024
15 checks passed
@sbachinin
Copy link
Collaborator Author

Noticed that marker loses opacity on window resize. Is it worth creating an issue?

@HarelM
Copy link
Collaborator

HarelM commented Jan 31, 2024

Can you attach a video?

@sbachinin
Copy link
Collaborator Author

sbachinin commented Jan 31, 2024

Untitled.Project.mp4

2 times it lost opacity, last time it didn't

@HarelM
Copy link
Collaborator

HarelM commented Jan 31, 2024

I would recommend opening a new issue, maybe an issue with the coordinates buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants