-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test opacity of a partly visible marker #3644
Conversation
For some reason codecov didn't send a message, can you make sure the line is now fully covered? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3644 +/- ##
==========================================
+ Coverage 86.61% 86.94% +0.32%
==========================================
Files 240 240
Lines 32214 32214
Branches 2132 2116 -16
==========================================
+ Hits 27903 28007 +104
+ Misses 3356 3258 -98
+ Partials 955 949 -6 ☔ View full report in Codecov by Sentry. |
From my understanding, this line is now ok. There are test cases that reach this line and execute both truthy and falsy part |
Noticed that marker loses opacity on window resize. Is it worth creating an issue? |
Can you attach a video? |
Untitled.Project.mp42 times it lost opacity, last time it didn't |
I would recommend opening a new issue, maybe an issue with the coordinates buffer. |
Concludes #3458