Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unnecessary variable projectionScaling from 3 shaders #4555

Closed

Conversation

zhangyiatmicrosoft
Copy link
Contributor

@zhangyiatmicrosoft zhangyiatmicrosoft commented Aug 13, 2024

Launch Checklist

A very minor touch up to remove an unnecessary variable projectionScaling, which was added in PR #4071.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (26d61c1) to head (79ab843).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4555      +/-   ##
==========================================
- Coverage   87.82%   87.80%   -0.02%     
==========================================
  Files         247      247              
  Lines       33492    33492              
  Branches     2234     2416     +182     
==========================================
- Hits        29413    29409       -4     
+ Misses       3070     3063       -7     
- Partials     1009     1020      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangyiatmicrosoft zhangyiatmicrosoft changed the title remove unnecessary variable projectionScaling from 3 shaders remove an unnecessary variable projectionScaling from 3 shaders Aug 13, 2024
@zhangyiatmicrosoft zhangyiatmicrosoft changed the title remove an unnecessary variable projectionScaling from 3 shaders Remove an unnecessary variable projectionScaling from 3 shaders Aug 13, 2024
@zhangyiatmicrosoft zhangyiatmicrosoft marked this pull request as ready for review August 13, 2024 18:15
@HarelM
Copy link
Collaborator

HarelM commented Aug 14, 2024

I think this is intended to avoid merge conflict with the globe branch, so I would keep it for now until we merge the globe branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants