Fix cluster radius scaling in setClusterOptions

[ciscorn]

The calculation for superclusterOptions.radius in GeoJSONSource.setClusterOptions is missing the necessary scaling, resulting in incorrect values.

For reference, the relevant initialization code can be found here:

maplibre-gl-js/src/source/geojson_source.ts

Line 160 in bc43205

const scale = EXTENT / this.tileSize;

maplibre-gl-js/src/source/geojson_source.ts

Line 185 in bc43205

radius: (options.clusterRadius || 50) * scale,

Note: setClusterOptions was introduced in #1998.

Launch Checklist

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Briefly describe the changes in this PR.
• Link to related issues.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.06%. Comparing base (bc43205) to head (0afac35).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5055      +/-   ##
==========================================
- Coverage   89.06%   89.06%   -0.01%     
==========================================
  Files         269      269              
  Lines       38318    38320       +2     
  Branches     2362     2366       +4     
==========================================
+ Hits        34129    34130       +1     
+ Misses       3187     3183       -4     
- Partials     1002     1007       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HarelM]

Thanks! I would advise to add a test to this case or modify an existing one.
Also consider making a small method out of this if it is used both for initialization and update.

[ciscorn]

@HarelM
Thanks. I've updated the expected values in the existing test and refactored the logic into a separate method.

[HarelM]

Thanks!
Can you add a changelog item?

[HarelM]

What is the hard coded 512?

[ciscorn]

I’ve replaced the hardcoded 512 with source.tileSize.

[HarelM]

Can we use the same method to scale the buffer input field, and rename it accordingly?

[ciscorn]

I renamed the method to _pixelsToTileUnits and applied it to scale those fields as well.

[HarelM]

Added a few nitpicking, looks good otherwise, THANKS!

[HarelM]

Thanks!